Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mentioning 'metrics' for the ACK controller service. #77

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Jun 2, 2021

Description of changes:

Explicitly mentioning 'metrics' for the ACK controller service.

Sample dry-run putput:

# Source: ack-apigatewayv2-controller/templates/metrics-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: somename-ack-apigatewayv2-controller-metrics
  namespace: default
  labels:
    app.kubernetes.io/name: ack-apigatewayv2-controller
    app.kubernetes.io/instance: somename
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "v0.0.2"
    k8s-app: ack-apigatewayv2-controller
    helm.sh/chart: ack-apigatewayv2-controller-v0.0.2
    control-plane: controller
spec:
  selector:
    app.kubernetes.io/name: ack-apigatewayv2-controller
    app.kubernetes.io/instance: somename
    app.kubernetes.io/managed-by: Helm
    k8s-app: ack-apigatewayv2-controller
  type: ClusterIP
  ports:
  - name: metricsport
    port: 8080
    targetPort: 8080
    protocol: TCP

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vijtrip2 vijtrip2 self-assigned this Jun 2, 2021
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 3aa29a0 into aws-controllers-k8s:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants