Remove unnecessary homedir module #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
/hold Might still need it. Golang is not good at expanding tilde |
ack-bot
added
the
do-not-merge/hold
|
/unhold It wasn't golang that sucked at expanding tilde, it was the fact we were explicitly passing tilde as the command line argument |
ack-bot
removed
the
do-not-merge/hold
|
Thanks @RedbackThomson ! :) /approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
#462) **Issue #** This issue arises from the code changes in lambda-controller for[ PR #88](aws-controllers-k8s/lambda-controller#88) **Summary** Support of injecting fields in existing structures: CustomNestedFields **Description** The code in this PR helps in accepting a custom nestedField defined using `type` as a part of its parentField. In the issue mentioned above when we inject a new field `S3SHA256` into `Code` struct, instead of nesting it under `Code` the generator created a separate field named `CodeS3SHA256`. The new field `S3SHA256` is defined like this in `generator.yaml` file: ``` Function: fields: Code.S3SHA256: type: string ``` After applying the changes in this PR, the field `S3SHA256` is properly injected as a part of `Code` struct. ``` type FunctionCode struct { ImageURI *string `json:"imageURI,omitempty"` S3Bucket *string `json:"s3Bucket,omitempty"` S3BucketRef *ackv1alpha1.AWSResourceReferenceWrapper `json:"s3BucketRef,omitempty"` S3Key *string `json:"s3Key,omitempty"` S3ObjectVersion *string `json:"s3ObjectVersion,omitempty"` S3SHA256 *string `json:"s3SHA256,omitempty"` ZipFile []byte `json:"zipFile,omitempty"` } ``` This PR contains code implementation to inject Nested fields into the Spec or Status struct and has respective model-test to validate the changes. **Acknowledgment** By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.UserHomeDiris supported in go1.12+. We no longer need a third party module to load the home directory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.