Can't deploy updated deployment package for Lambda with ACK

[timam]

Describe the bug
I have created a lambda fuction with ACK. I am using a file from s3 to deploy lambda.
Now, I have a new deployment package and want ack to deploy the new package. Unfortunately, ack is giving me following error.

This resource already exists but is not managed by ACK. To bring the resource under ACK management, you should explicitly adopt the resource by creating a services.k8s.aws/AdoptedResource

Steps to reproduce
Create deployment package and upload it to s3
Create a lambda fuction with ACK with newly updated deployment package to s3
Make any code change, package it and upload it to s3 with a seperate name
Update yaml with new deployment package name
Deploy changes

Expected outcome
It should update lambda package

Environment

• Kubernetes version
  1.23
• Using EKS (yes/no), if so version?
  EKS 1.23
• AWS service targeted (S3, RDS, etc.)
  Lambda

[a-hilaly]

Hi @timam can you provide similar yaml files to what you wanted to deploy? I would like to reproduce the same bugs using the same steps.

[timam]

Hey @a-hilaly

I have created a helm chart with following yaml.

apiVersion: lambda.services.k8s.aws/v1alpha1
kind: Function
metadata:
  name: {{ .Values.function_name }}
  namespace: {{ .Values.namespace }}
  annotations:
    services.k8s.aws/region: {{ .Values.aws_region }}
spec:
  name: {{ .Values.function_name }}
  code:
    s3Bucket:  {{ .Values.artifact_bucket }}
    s3Key: {{ .Values.function_name }}/{{ .Values.artifact_tag }}
  role: {{ .Values.iam_role }}
  runtime: {{ .Values.runtime }}
  memorySize: {{ .Values.memory }}
  timeout: {{ .Values.timeout }}
  handler: {{ .Values.handler }}
  description: {{ .Values.function_name }} created by ACK lambda-controller
  environment:
    variables:
      {{- range $key, $val := .Values.env_vars }}
        {{ $key }} : {{ $val | quote }}
      {{- end }}
  vpcConfig:
    securityGroupIDs:
      - {{ .Values.security_group_id }}
    subnetIDs:
      {{- range .Values.subnet_ids }}
        - {{ . | quote }}
      {{- end }}

Next i have created a argocd pipeline. To deploy this helm chart. I supply all the helm values from a seperate (deployment) git repo.

I was able to successfully create lambda with this approch. The problem is, when I update the value of artifact_tag in deployment git repo, argocd syncs it but the updated package doesn't get deployed.

This resource already exists but is not managed by ACK.

I deleted and recreated the lambda, the issue was resolved however, i am still enable to deploy updated package with ack-lambda with mentioned approch.

[boris-ait]

Same here. It seems like the lambda's code is getting updated just once when the function was created. BTW the environment variables of lambda are updated when you update the function manifest.
Of course, you can delete and then recreate the function resource, so the lambda's code will be updated according to the function manifest. However, that does not suit for GitOps approach.

[a-hilaly]

/assign @Vandita2020

[ack-prow]

@a-hilaly: GitHub didn't allow me to assign the following users: Vandita2020.

Note that only aws-controllers-k8s members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Vandita2020

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Vandita2020]

/assign

[ack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[ack-bot]

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[Vandita2020]

Closing this issue as the PR to support updating deployment package for Lambda functions in ACK is merged.

[Vandita2020]

/close

[ack-prow]

@Vandita2020: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.