Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: deployment / selector labels to isolate pods per controller #1632

Closed
codekow opened this issue Jan 14, 2023 · 0 comments
Closed

Add: deployment / selector labels to isolate pods per controller #1632

codekow opened this issue Jan 14, 2023 · 0 comments
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation service/all Indicates issues or PRs related to all the service controllers.

Comments

@codekow
Copy link

codekow commented Jan 14, 2023

Describe the bug

Selecting pods and resources collide due to a lack of labeling and selectors in the deployment and service definintions

Steps to reproduce

oc get -l control-plane=controller -n ack-system
kubectl get -l control-plane=controller -n ack-system

All controller pods are shown and you cannot select pods for a single controller

The metrics services do not select pods on a single service - metrics gathering is problematic

Expected outcome

Use label selectors that allow you to isolate pods on each controller

Environment

  • Kubernetes version: OpenShift 4.10
  • Using EKS (yes/no), if so version? No
  • AWS service targeted (S3, RDS, etc.) ALL
@codekow codekow mentioned this issue Jan 14, 2023
Merged
@a-hilaly a-hilaly added area/code-generation Issues or PRs as related to controllers or docs code generation service/all Indicates issues or PRs related to all the service controllers. labels Jan 25, 2023
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue Jan 27, 2023
@codekow
add: specific selector for operator (#390)
6713768 
Issue #, if available: [#1632](aws-controllers-k8s/community#1632)

Description of changes:

Improve label selection for service and deployment association with pods. When multiple operators are deployed you may get inconsistent results on the service.

Related [s3-controller/pull/94](aws-controllers-k8s/s3-controller#94)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@a-hilaly a-hilaly closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation service/all Indicates issues or PRs related to all the service controllers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-hilaly @codekow