Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda function is not updated when s3Key changed #2067

Closed
blueacidification opened this issue Apr 27, 2024 · 6 comments
Closed

Lambda function is not updated when s3Key changed #2067

blueacidification opened this issue Apr 27, 2024 · 6 comments
Assignees
Labels
service/lambda Indicates issues or PRs that are related to lambda-controller.

Comments

@blueacidification
Copy link

blueacidification commented Apr 27, 2024

Describe the bug
My team uses gitops to deploy apps in kubernetes, we thought we could do the same for lambdas.

Steps to reproduce
Apply manifest.

function.yaml

apiVersion: lambda.services.k8s.aws/v1alpha1
kind: Function
metadata:
 name: test-lambda-access-2
 annotations:
   services.k8s.aws/region: eu-central-1
spec:
 name: test-lambda-access-2
 code:
   s3Bucket: lambda-function-devops
   s3Key: my-deployment-package-1.zip
 role: arn:aws:iam::535479077865:role/lambda_basic_execution
 runtime: python3.9
 handler: lambda_function.lambda_handler
 description: function created by ACK lambda-controller e2e tests

Change the s3Key.
The function says successfully synced and has the latest changes.
The function does NOT update on AWS.

Expected outcome
The function is updated with the expected s3Key.

Environment

  • Kubernetes version 1.28
  • Using EKS (yes/no), if so version? 1.28
  • AWS service targeted (S3, RDS, etc.) s3
@blueacidification blueacidification changed the title Function is not updated when s3Key changed Lambda function is not updated when s3Key changed Apr 27, 2024
@a-hilaly a-hilaly added the service/lambda Indicates issues or PRs that are related to lambda-controller. label May 1, 2024
@a-hilaly
Copy link
Member

a-hilaly commented May 1, 2024

/assign @Vandita2020

@Vandita2020
Copy link
Member

Hey @blueacidification,
Thanks for bringing your issue. We are aware of this issue and are working on it. You can keep a track with this PR.

@blueacidification
Copy link
Author

Thank you, can't wait for the results!

@Vandita2020
Copy link
Member

Hey @blueacidification,
Letting you know that the support for updating S3Key is available now in ACK. Please go and checkout the feature. Thanks!

@Vandita2020
Copy link
Member

/close

Copy link

ack-prow bot commented May 7, 2024

@Vandita2020: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/lambda Indicates issues or PRs that are related to lambda-controller.
Projects
None yet
Development

No branches or pull requests

3 participants