Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NestedFields to support Lists #789

Closed
mbaijal opened this issue May 18, 2021 · 5 comments
Closed

Allow NestedFields to support Lists #789

mbaijal opened this issue May 18, 2021 · 5 comments
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mbaijal
Copy link
Contributor

mbaijal commented May 18, 2021

Is your feature request related to a problem?
Some CRD fields contain a list of nested objects which should also be allowed to be referred/marked for various purposes. Refer to Code-Generator PR#47.

An example of this use case would be the DescribeScalableTargets API call.
At the moment, this API does not return any status field in the response and hence I would like to be able to add the CreationTime as a metadata field using something like -

resources:
  ScalableTarget:
    fields:
      ResourceID:
        is_read_only: true
        is_arn: true
        from:
          operation: DescribeScalableTargets
          path: ScalableTargets..ResourceId

This currently fails with the following error, but should successfully add the desired sub-field to the object status:

panic: unknown additional Status field with Op: DescribeScalableTargets and Path: ScalableTargets..CreationTime

Describe the solution you'd like
Support for parsing CRD subfields that are lists.

@mbaijal mbaijal added the kind/enhancement Categorizes issue or PR as related to existing feature enhancements. label May 18, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 28, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2021
@a-hilaly
Copy link
Member

/remove-lifecycle stale

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 29, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 29, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-bot
Copy link
Collaborator

ack-bot commented Oct 29, 2021

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants