Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACK runtime pkg/compare/Delta.DifferentAt is not working with fields JSON-Paths #808

Closed
a-hilaly opened this issue Jun 3, 2021 · 1 comment
Assignees
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Jun 3, 2021

Describe the bug
delta.DifferentAt doesn't work as expected when getting fields JSON-Path as input - see differentAt unit tests

delta.Add("Spec.X.Y.Z", a, b)
delta.DifferentAt("Spec.X.Y") // returns false
delta.DifferentAt("Y")        // returns true

Expected outcome

delta.Add("Spec.X.Y.Z", a, b)
delta.DifferentAt("Spec.X.Y") // should return true
delta.DifferentAt("Y")        // should return false

/priority important-soon
/good-first-issue
/help-wanted

@a-hilaly a-hilaly added kind/bug Categorizes issue or PR as related to a bug. area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc labels Jun 3, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 3, 2021

@a-hilaly:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Describe the bug
delta.DifferentAt doesn't work as expected when getting fields JSON-Path as input - see differentAt unit tests

delta.Add("Spec.X.Y.Z", a, b)
delta.DifferentAt("Spec.X.Y") // returns false
delta.DifferentAt("Y")        // returns true

Expected outcome

delta.Add("Spec.X.Y.Z", a, b)
delta.DifferentAt("Spec.X.Y") // should return true
delta.DifferentAt("Y")        // should return false

/priority important-soon
/good-first-issue
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 3, 2021
@echen-98 echen-98 self-assigned this Jun 4, 2021
ack-bot pushed a commit to aws-controllers-k8s/runtime that referenced this issue Jun 8, 2021
@a-hilaly a-hilaly closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants