Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating documentation for OpenShift user-config and secrets #1232

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

acornett21
Copy link
Contributor

Issue #, if available:

Description of changes:
Adding in documentation to support service specific configmaps and secrets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@acornett21
Copy link
Contributor Author

@komish Please take a look.

@komish
Copy link
Contributor

komish commented Mar 24, 2022

I'm not a review but this looks good
/lgtm

@ack-bot
Copy link
Collaborator

ack-bot commented Mar 24, 2022

@komish: changing LGTM is restricted to collaborators

In response to this:

I'm not a review but this looks good
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @acornett21!

@ack-bot
Copy link
Collaborator

ack-bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, jaypipes, komish, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes
Copy link
Collaborator

/lgtm

@vijtrip2 vijtrip2 merged commit 8f6ceca into aws-controllers-k8s:main Mar 24, 2022
@acornett21 acornett21 deleted the update_openshift_doc branch March 24, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants