Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adoption by annotation logic and tests #123

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add Adoption by annotation logic and tests #123

merged 1 commit into from
Dec 11, 2024

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Dec 4, 2024 •
edited
Loading

Description of changes:
resources tested:

  • Policy
  • Role

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jaypipes December 4, 2024 23:26
@michaelhtm michaelhtm force-pushed the add/adoption-test branch 3 times, most recently from d479ba9 to cac728e Compare December 10, 2024 19:50
@michaelhtm
Add Adoption by annotation logic and tests
677d0cf 
resources tested:
* Policy
* Role
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 10, 2024 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-verify-attribution 677d0cf link false /test iam-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelhtm rock in, sir!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 11, 2024
@ack-prow ack-prow bot merged commit 026f1ae into aws-controllers-k8s:main Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @a-hilaly