Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple ACK resource tag formats #88

Merged
merged 1 commit into from
May 24, 2022

Conversation

vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1261

Description of changes:

  • support '%CONTROLLER_SERVICE%' , '%CONTROLLER_VERSION%', '%K8S_NAMESPACE%' and '%K8S_RESOURCE_NAME%' as the resource tag format
  • support tag format as substring, and not just complete tag value
  • As per the comment , I did not add 'OWNER_ACCOUNT_ID' because any AWS related information will be known to customer when describing tags or viewing the resource in AWS console.
  • I also did not add 'K8S_CRD_VERSION' right now and waiting for multi version support , to find out the best place to find the k8s resource crd version.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pkg/runtime/tags.go Outdated Show resolved Hide resolved
pkg/runtime/tags.go Outdated Show resolved Hide resolved
pkg/runtime/tags.go Outdated Show resolved Hide resolved
pkg/runtime/tags.go Outdated Show resolved Hide resolved
@vijtrip2 vijtrip2 force-pushed the multiple-res-tag-formats branch from 4567794 to 849d6c8 Compare May 23, 2022 20:09
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-hilaly
Copy link
Member

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 50de420 into aws-controllers-k8s:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants