model resource unit tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaijal
suggested changes
Sep 8, 2021
pkg/resource/model/testdata/sdkapi/describe/success_primary_container.json
Show resolved
Hide resolved
| output_fixture: "sdkapi/create/create_success.json" | ||
| invoke: Create | ||
| expect: | ||
| latest_state: "v1alpha1/create/observed/success_after_create.yaml" |
There was a problem hiding this comment.
same, filenames should be in pattern with name in line 16
There was a problem hiding this comment.
couldnt think of better naming but I agree, there should be a pattern to make it more readable
surajkota
force-pushed
the
model_unit
branch
from
e5a41fd to
2232a08
Compare
ryansteakley
approved these changes
Sep 14, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.