Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AWS GoSDK version to v1.38.11 #9

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Upgrade AWS GoSDK version to v1.38.11 #9

merged 1 commit into from
Apr 6, 2021

Conversation

akartsky
Copy link
Member

@akartsky akartsky commented Mar 29, 2021 •
edited
Loading

Upgrade to the latest version of AWS GoSDK.

This update includes the Artifactory Auth Support for Hosting

All integ tests passed

RedbackThomson
RedbackThomson approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great, this also includes environment variable support for training!

mbaijal
mbaijal approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@mbaijal mbaijal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you sync with Suraj's changes as discussed ?

surajkota
surajkota requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT merge this PR as-is. Please rebase once #7 is merged and use the latest version(338d010225939a25b2e175594fec29b56707b388) of code generator and runtime 0.0.5

Also please git add files necessary for the PR

config/crd/bases/sagemaker.services.k8s.aws_hyperparametertuningjobs.yaml Outdated Show resolved Hide resolved
@akartsky akartsky force-pushed the update_version_1.38.7 branch from d325592 to cffec6f Compare April 2, 2021 17:05
@akartsky akartsky changed the title Upgrade AWS GoSDK version to v1.38.7 Upgrade AWS GoSDK version to v1.38.11 Apr 2, 2021
@akartsky
Copy link
Member Author

akartsky commented Apr 2, 2021

Do NOT merge this PR as-is. Please rebase once #7 is merged and use the latest version(338d010225939a25b2e175594fec29b56707b388) of code generator and runtime 0.0.5

Also please git add files necessary for the PR

Made all changes
ready to merge

surajkota
surajkota requested changes Apr 2, 2021
View reviewed changes
apis/v1alpha1/endpoint.go Outdated Show resolved Hide resolved
@akartsky akartsky force-pushed the update_version_1.38.7 branch from cffec6f to dccb427 Compare April 6, 2021 23:24
@surajkota surajkota merged commit 41e4a1b into aws-controllers-k8s:main Apr 6, 2021
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 17, 2021
@akartsky
Upgrade AWS GoSDK version to v1.38.11 (aws-controllers-k8s#9)
2f43630
ryansteakley pushed a commit to ryansteakley/sagemaker-controller that referenced this pull request May 18, 2021
@akartsky @ryansteakley
Upgrade AWS GoSDK version to v1.38.11 (aws-controllers-k8s#9)
6c6ec97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedbackThomson RedbackThomson RedbackThomson approved these changes

@jaypipes jaypipes jaypipes left review comments

@mbaijal mbaijal mbaijal approved these changes

@surajkota surajkota surajkota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akartsky @jaypipes @RedbackThomson @surajkota @mbaijal