ci: add PyPI publish job to publish workflow #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
changed the title
Signed-off-by: Charles Moore <moorec@amazon.com>
moorec-aws
force-pushed
the
moorec/add-contents-write
branch
from
882fd94
to
8621ea8
Compare
jusiskin
approved these changes
Apr 25, 2024
ddneilson
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
PyPI publishing does not support reusable workflows, there is an open issue to add support:
pypi/warehouse#11096
For now we need to keep publishing to pypi as a job in the publish workflow file of each repository so that it can authenticate to publish.
The Release job in the reusable publish workflow requires contents write permissons.
https://github.com/OpenJobDescription/.github/blob/mainline/.github/workflows/reusable_publish.yml#L35
What was the solution? (How)
What is the impact of this change?
Move PyPI publishing job back to each repository instead of using a reusable workflow
How was this change tested?
Tested in a developer github account
Was this change documented?
no
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.