feat: allow worker config tests to disallow instance profile #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li <52769999+YutongLi291@users.noreply.github.com>
|
AlexTranAmz
approved these changes
Nov 12, 2024
hindleym
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
For some of the worker agent e2e tests, we would like to verify the worker agent behaviour when we disallow instance profile (one of the worker install options)
What was the solution? (How)
Allow this option in the worker test fixture.
What is the impact of this change?
Allows the worker e2e tests to verify worker agent behaviour when we disallow instance profiles.
How was this change tested?
hatch run fmt && hatch run lint && hatch run test && hatch buildVerify the option exists in the installer.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.