fix: change windows logon type from NETWORK to INTERACTIVE #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
previously approved these changes
Mar 21, 2024
ddneilson
force-pushed
the
ddneilson/logon_kind
branch
from
7592fd0
to
a261507
Compare
moorec-aws
approved these changes
Mar 21, 2024
epmog
approved these changes
Mar 21, 2024
jusiskin
approved these changes
Mar 21, 2024
epmog
force-pushed
the
ddneilson/logon_kind
branch
from
a261507
to
d56b836
Compare
Problem: Some applications have security controls that restrict what a network logon user can do, but do not have such restrictions for interactive logons. Solution: Change the win32 logon kind from NETWORK to INTERACTIVE. NETWORK was oridinally chosen as it was believed that it was required for the logon to have access to network shares, but INTERACTIVE grants the same access so this should be a safe change. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/logon_kind
branch
from
d56b836
to
8fba911
Compare
Merged
baxeaz
pushed a commit
that referenced
this pull request
Mar 23, 2024
Problem: Some applications have security controls that restrict what a network logon user can do, but do not have such restrictions for interactive logons. Solution: Change the win32 logon kind from NETWORK to INTERACTIVE. NETWORK was oridinally chosen as it was believed that it was required for the logon to have access to network shares, but INTERACTIVE grants the same access so this should be a safe change. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Some applications have security controls that restrict what a network logon user can do, but do not have such restrictions for interactive logons.
What was the solution? (How)
Change the win32 logon kind from NETWORK to INTERACTIVE. NETWORK was oridinally chosen as it was believed that it was required for the logon to have access to network shares, but INTERACTIVE grants the same access so this should be a safe change.
What is the impact of this change?
Applications that restrict network logons should now function.
How was this change tested?
A colleague manually applied the change and tested it with the application in question.
Was this change documented?
N/A
Is this a breaking change?
No, it should not be.