Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Deadline Client Lib to telemetry and add a success/fail decorator… #352

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

leongdl
Copy link
Contributor

@leongdl leongdl commented Jul 5, 2024

What was the problem/requirement? (What/Why)

  • Currently we lack telemetry when Job Attachments is downloaded or output is uploaded from S3. There is insufficient metrics to know if a particular release (or dependency release) has regressions.

What was the solution? (How)

  • Add success / fail telemetry metrics to Job Attachments download and upload functions. This is a generic try-catch metric that is useful as a canary. This will provide traceability to detect any regression.

What is the impact of this change?

  • More traceability into Worker Agent and Job Attachments execution.

How was this change tested?

  • hatch build
  • hatch run fmt
  • hatch run test
------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                         4808    672   2110    204    84%
Coverage HTML written to dir build/coverage
Coverage XML written to file build/coverage/coverage.xml

Required test coverage of 80.0% reached. Total coverage: 84.42%
========================================================================================================== slowest 5 durations ==========================================================================================================

Was this change documented?

  • Not Applicable.

Is this a breaking change?

  • No.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@leongdl leongdl requested a review from a team as a code owner July 5, 2024 22:01
@epmog epmog changed the title Add Deadline Client Lib to telemetry and add a success/fail decorator… feat: add Deadline Client Lib to telemetry and add a success/fail decorator… Jul 5, 2024
@leongdl leongdl force-pushed the telemetry2 branch 2 times, most recently from 0d341ff to ecfc085 Compare July 9, 2024 22:27
jairaws
jairaws previously approved these changes Jul 10, 2024
crowecawcaw
crowecawcaw previously approved these changes Jul 10, 2024
src/deadline_worker_agent/aws/deadline/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>
@leongdl leongdl merged commit ac1e5e0 into aws-deadline:mainline Jul 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants