Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added SQS queue creation with events for Karpenter #1458

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Feb 25, 2023

‼️ PLEASE READ THIS FIRST ‼️

The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.

We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.

Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue #1421

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Creates a new SQS Queue and CW Events for Karpenter to handle Spot Node termination

Note: Users who want to pass existing sqs_queue_arn can still be passed through karpenter_helm_config values.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu requested a review from a team as a code owner February 25, 2023 19:37
@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test February 25, 2023 20:30 — with GitHub Actions Inactive
@vara-bonthu vara-bonthu merged commit a9181ae into main Feb 25, 2023
@vara-bonthu vara-bonthu deleted the karpenter-changes branch February 25, 2023 20:50
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Karpenter add-on to support Spot interruption
2 participants