Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding ListRules permission in prometheus module for addon #1460

Closed
wants to merge 2 commits into from

Conversation

malikdraz
Copy link

@malikdraz malikdraz commented Feb 27, 2023

‼️ PLEASE READ THIS FIRST ‼️

The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.

We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.

Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue #1421

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@malikdraz malikdraz requested a review from a team as a code owner February 27, 2023 00:03
@malikdraz malikdraz temporarily deployed to EKS Blueprints Test February 27, 2023 00:03 — with GitHub Actions Inactive
@malikdraz malikdraz changed the title added aps:ListRules in prometheus module for addon fix: added aps:ListRules in prometheus module for addon Feb 27, 2023
@malikdraz malikdraz changed the title fix: added aps:ListRules in prometheus module for addon fix: updating aps:ListRules in prometheus module for addon Feb 27, 2023
@malikdraz malikdraz changed the title fix: updating aps:ListRules in prometheus module for addon fix: adding ListRules permission in prometheus module for addon Feb 27, 2023
@malikdraz malikdraz changed the title fix: adding ListRules permission in prometheus module for addon fix: Adding ListRules permission in prometheus module for addon Feb 27, 2023
@vara-bonthu
Copy link
Contributor

Please explain the issue and how this fix solves

@vara-bonthu vara-bonthu closed this Mar 9, 2023
@vara-bonthu vara-bonthu reopened this Mar 9, 2023
@vara-bonthu vara-bonthu had a problem deploying to EKS Blueprints Test March 9, 2023 13:58 — with GitHub Actions Failure
@malikdraz
Copy link
Author

Hi @vara-bonthu When using AMP with AMG and trying to view the rules by clicking on the tab on the left, it does not show anything, and it gives a permission error that it requires "aps:ListRule". Once updated (manually), it fixes, and you re able to list rules and make changes accordingly.

@bryantbiggs
Copy link
Contributor

thank you for the PR - this will be resolved in the new addons module https://github.com/aws-ia/terraform-aws-eks-blueprints-addons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants