Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-for-fluentbit): Add missing action in CW policy #1478

Closed
wants to merge 1 commit into from

Conversation

fabidick22
Copy link

What does this PR do?

Update aws-for-fluentbit policy, the service account does not have enough permissions to set a log retention policy, this generates errors when fluentbit wants to create a log group.

time="2023-03-04T18:45:59Z" level=error msg="AccessDeniedException: User: arn:aws:sts::00000:assumed-role/CLUSTER-aws-for-fluent-bit-sa-irsa/1111111111 is not authorized to perform: logs:PutRetentionPolicy on resource: arn:aws:logs:us-east-1:00000:log-group:/cluster/fluentbit-logs/namespace/app:log-stream: because no identity-based policy allows the logs:PutRetentionPolicy action\n\tstatus code: 400, request id: 0000000" 

Motivation

Configure fluentbit to create a resource group for each application in kubernetes

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@fabidick22 fabidick22 requested a review from a team as a code owner March 4, 2023 18:49
@fabidick22 fabidick22 temporarily deployed to EKS Blueprints Test March 4, 2023 18:49 — with GitHub Actions Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@askulkarni2
Copy link
Contributor

@fabidick22 can you please re-open this PR against https://github.com/aws-ia/terraform-aws-eks-blueprints-addons repo. This is going to be the new home for add-ons as a part of changes under #1421. Apologies for the duplicate effort.

@fabidick22
Copy link
Author

@fabidick22 fabidick22 closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants