feat: Update CBR example to use EKS managed node group #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askulkarni2
approved these changes
Jul 5, 2024
|
|
||
| # Note: ML capacity block reservations are only supported | ||
| # on self-managed node groups at this time | ||
| self_managed_node_groups = { |
There was a problem hiding this comment.
Should we leave the self-managed example in there as well for those may need it?
There was a problem hiding this comment.
ya I guess it doesn't hurt to show both - let me update
There was a problem hiding this comment.
re-added in 193b135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v20.17.0feat: Add support for ML capacity block reservations with EKS managed node group(s) terraform-aws-modules/terraform-aws-eks#3091Motivation and Context
How was this change tested?
t3.smallCBRpre-commit run -awith this PRAdditional Notes