Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: managed policy arns deprecated #6

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

scottschreckengaust
Copy link
Collaborator

Updating deprecation warning:

│ Warning: Argument is deprecated
│ 
│   with module.serverless-streamlit-app.aws_iam_role.eventbridge_invoke_streamlit_event_bus,
│   on .terraform/modules/serverless-streamlit-app/main.tf line 1313, in resource "aws_iam_role" "eventbridge_invoke_streamlit_event_bus":
│ 1313:   managed_policy_arns = [
│ 1314:     aws_iam_policy.eventbridge_invoke_streamlit_event_bus_policy.arn,
│ 1315:   ]
│ 
│ The managed_policy_arns argument is deprecated. Use the aws_iam_role_policy_attachment resource instead. If Terraform shouldexclusively manage all managed policy attachments
│ (the current behavior of this argument), use the aws_iam_role_policy_attachments_exclusive resource as well.
│ 
│ (and 6 more similar warnings elsewhere)

Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@scottschreckengaust scottschreckengaust marked this pull request as draft November 9, 2024 15:53
@scottschreckengaust
Copy link
Collaborator Author

scottschreckengaust commented Nov 9, 2024

Hashicorp AWS provider's minimum version for this feature is 5.72.0.

Some additional checks that were fixed:

  • Supress checkov rule to allow HTTP on load balancers because behind Amazon CloudFront.
  • Add an empty array to have a geographical restriction for CloudFront.

@scottschreckengaust scottschreckengaust marked this pull request as ready for review November 9, 2024 17:09
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@novekm
Copy link
Collaborator

novekm commented Nov 10, 2024

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants