Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edits to soak tests #67

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

NathanielRN
Copy link
Contributor

@NathanielRN NathanielRN commented Sep 27, 2021

Description

Follow up to #65, we make some small edits to the Soak Tests:

  1. Delete oldest snapshots in the commits/<current_commit_id>/runs/ folder as well as the commits/ folder.
  2. With Support repo.repo and repo.owner as template variables JasonEtco/create-an-issue#114 merged, we can use the upstream JasonEtco/create-an-issue action again! (This will be broken until the next minor release)
  3. Deleting LOG_STREAM_NAME from the comments because it is not used as an environment variable anymore
  4. Change the protocol from grpc:// to http:// to match java and go which only accept http://
  5. Update the list of environment variables used for the app during Soak Tests

@NathanielRN NathanielRN marked this pull request as draft September 27, 2021 19:50
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long run, e.g. when upstreaming, could we extract all of these tests into an action so that we don't have to update every repo with each change?

@NathanielRN NathanielRN force-pushed the edits-to-soak-tests branch 2 times, most recently from ba6308e to 1ce5d5e Compare September 28, 2021 18:16
@NathanielRN
Copy link
Contributor Author

In the long run, e.g. when upstreaming, could we extract all of these tests into an action so that we don't have to update every repo with each change?

Totally! That would be an awesome improvement 😄

I think they are well set up to be made into an action. We saw the translation to the rest of the repos go fairly smoothly, so off the top of my head as an action it would need to know the following:

  • The commit at which to checkout the current repo
  • The location on the current repo for each Sample App to build and Soak Test
  • A unique way to identify each Sample App (Usually "platform framework" + "auto/manual instrumentation")
  • AWS credentials
  • The Process executable name and command line command to identify the process (although maybe we could find this out independently by checking our the diff of actual vs expected processes on a runner)
  • Whether to include the otlp metrics receiver (for now while some languages don't have them)

And I just realized we should probably make all the Soak Tests use OTEL_EXPORTER_OTLP_ENDPOINT=http://otel:4317 because some using http://, grpc:// or nothing at all.. I added it to this PR but it's not an urgent fix I would say 😄

@NathanielRN NathanielRN marked this pull request as ready for review September 28, 2021 18:19
@anuraaga anuraaga merged commit 915f43e into aws-observability:main Sep 29, 2021
@NathanielRN NathanielRN deleted the edits-to-soak-tests branch September 29, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants