Skip to content

Commit

Permalink
Fail artifact build if load and push are both false (#195)
Browse files Browse the repository at this point in the history
If both are false, we get somewhat arcane failures. All existing
workflows set one to true and the other to false, this just enforces it.

Also, Fix a codespell issue that was introduced in 2.3.0 (previously
using 2.2.6).

Testing: Set both options to false in pr_build-
https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/9230011064/job/25397368739?pr=195

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
thpierce authored May 24, 2024
1 parent 6c3576d commit 41daf45
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .codespellrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[codespell]
# skipping auto generated folders
skip = ./.tox,./.mypy_cache,./target,*/LICENSE,./venv,*/sql_dialect_keywords.json
ignore-words-list = afterall
ignore-words-list = afterall,assertIn
7 changes: 7 additions & 0 deletions .github/actions/artifacts_build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ inputs:
runs:
using: "composite"
steps:
- name: Action verification
if: ${{ (inputs.load_image == false || inputs.load_image == 'false') && (inputs.push_image == false || inputs.push_image == 'false') }}
shell: bash
run: |
echo "At least one of push_image or load_image must be true"
exit 1
- name: Set up
uses: ./.github/actions/set_up
with:
Expand Down

0 comments on commit 41daf45

Please sign in to comment.