Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.19.0 #569

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

williazz
Copy link
Contributor

@williazz williazz commented Jul 9, 2024

Changelog

All notable changes to this project will be documented in this file. See standard-version for commit guidelines.

1.19.0 (2024-07-09)

Features

  • support unique credential cookie names (#560) (a440016)

Bug Fixes

1.18.0 (2024-05-29)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@williazz williazz marked this pull request as ready for review July 9, 2024 18:00

### Bug Fixes

* reduce CDN size by tree shaking ([#563](https://github.com/aws-observability/aws-rum-web/issues/563)) ([c2da86e](https://github.com/aws-observability/aws-rum-web/commit/c2da86e8e92b8ca294f32de1d8ed8ded654762ca))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: does this count as a bug fix? not sure if we should be including it here in the changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was bug in our tree shaking, likely caused by a regression in f63150d


### Features

* support unique credential cookie names ([#560](https://github.com/aws-observability/aws-rum-web/issues/560)) ([a440016](https://github.com/aws-observability/aws-rum-web/commit/a440016e402ed03e5fb463e13d1bdde13dfe5f40))
Copy link
Member

@qhanam qhanam Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: We've historically capitalized the first letter in the commit message. E.g., feat: Support unique credential cookie names.

This was, in part, so that entries in the CHANGELOG would be capitalized. Can we use this convention more consistently going forward?

@williazz williazz merged commit d21d462 into aws-observability:release/1.19.x Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants