Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated Metrics implementation and tests to use AOP #31

Merged
merged 3 commits into from
Dec 8, 2021
Merged

feat: Updated Metrics implementation and tests to use AOP #31

merged 3 commits into from
Dec 8, 2021

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Dec 7, 2021

Description of changes:

  • Updated Metrics implementation and tests to use AspectInjector.
  • Updated code example to use the new Metrics Aspect implementation.
  • Removed codecov information from Readme.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@t1agob t1agob requested a review from amirkaws December 7, 2021 13:17
@sliedig sliedig merged commit bcffd35 into aws-powertools:develop Dec 8, 2021
@t1agob t1agob added area/metrics Core metrics utility enhancement labels Jan 18, 2022
@t1agob t1agob changed the title Updated Metrics implementation and tests to use AspectInjector feat: Updated Metrics implementation and tests to use AOP Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirkaws amirkaws Awaiting requested review from amirkaws

Assignees
No one assigned
Labels
area/metrics Core metrics utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t1agob @sliedig