Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AOT support for Idempotency #653

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Sep 26, 2024

Please provide the issue number

Issue number: #212

Summary

Changes

Support for AOT in Idempotency and JMESPath.

Done:

  • Add JMESPathSerializationContext.cs and Serializer.
  • Add Idempotency IdempotencySerializationContext.cs and Serializer.
  • Update code to use both serializers

User experience

For serlializing client types inside Idempotency we now have a new method WithJsonSerializationContext.
This method receives the client JsonSerializationContext

image

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

…dempotencySerializationContext.cs and Serializer. Update code to use both serializers
@hjgraca hjgraca added this to the .NET AOT milestone Sep 26, 2024
@auto-assign auto-assign bot requested review from amirkaws and sliedig September 26, 2024 18:25
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 26, 2024
@github-actions github-actions bot added the internal Maintenance changes label Sep 26, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 79.72973% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.05%. Comparing base (4ab0fea) to head (1c2c997).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...ency/Internal/Serializers/IdempotencySerializer.cs 69.23% 7 Missing and 5 partials ⚠️
...mbda.Powertools.Idempotency/IdempotentAttribute.cs 50.00% 0 Missing and 1 partial ⚠️
...S.Lambda.Powertools.JMESPath/Values/DoubleValue.cs 0.00% 1 Missing ⚠️
...bda.Powertools.JMESPath/Values/JsonElementValue.cs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
+ Coverage    72.99%   73.05%   +0.06%     
===========================================
  Files          196      198       +2     
  Lines         8013     8068      +55     
  Branches       856      862       +6     
===========================================
+ Hits          5849     5894      +45     
- Misses        1877     1883       +6     
- Partials       287      291       +4     
Flag Coverage Δ
unittests 73.05% <79.72%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aot area/idempotency internal Maintenance changes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tests
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant