Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(examples): Add example for the powertools-cloudformation module #1089

Merged
merged 7 commits into from
Jul 19, 2023
Merged

build(examples): Add example for the powertools-cloudformation module #1089

merged 7 commits into from
Jul 19, 2023

Conversation

mriccia
Copy link
Contributor

@mriccia mriccia commented Mar 15, 2023 •
edited
Loading

Issue #, if available: #1081

Description of changes:

Adding a code example for the powertools-cloudformation module to demonstrate the functionality and share a more complete example of a CloudFormation custom resource

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.24 🎉

Comparison is base (ba8075f) 78.94% compared to head (eace5ee) 79.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1089      +/-   ##
============================================
+ Coverage     78.94%   79.19%   +0.24%     
- Complexity      629      639      +10     
============================================
  Files            72       73       +1     
  Lines          2332     2360      +28     
  Branches        253      258       +5     
============================================
+ Hits           1841     1869      +28     
+ Misses          412      410       -2     
- Partials         79       81       +2

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mriccia mriccia self-assigned this Apr 3, 2023
jeromevdl
jeromevdl reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there...

@mriccia mriccia requested a review from jeromevdl July 17, 2023 13:47
jeromevdl
jeromevdl approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeromevdl jeromevdl merged commit 8da24cb into aws-powertools:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msailes msailes msailes left review comments

@stevehouel stevehouel stevehouel left review comments

@jeromevdl jeromevdl jeromevdl approved these changes

@scottgerring scottgerring Awaiting requested review from scottgerring

Assignees

@mriccia mriccia

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mriccia @codecov-commenter @jeromevdl @scottgerring @stevehouel @msailes