Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParamManager cannot provide default SSM & Secrets providers #1282

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available: #1280

Description of changes:

  • It was partially fixed in c7aedc4 with the addition of constructors with no client in parameter
  • Completed the fix, adding the creation of the Client
  • Deprecated the generic method to get Providers by passing a class (will be removed in V2)

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@roamingthings roamingthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the implementation is very good readable and understandable

…ertools/parameters/ParamManager.java


missing issue number
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 34.28% and project coverage change: +0.10 🎉

Comparison is base (a19def3) 79.08% compared to head (9140cf2) 79.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1282      +/-   ##
============================================
+ Coverage     79.08%   79.18%   +0.10%     
- Complexity      634      639       +5     
============================================
  Files            73       73              
  Lines          2352     2359       +7     
  Branches        256      258       +2     
============================================
+ Hits           1860     1868       +8     
+ Misses          412      410       -2     
- Partials         80       81       +1     
Impacted Files Coverage Δ
...lambda/powertools/parameters/DynamoDbProvider.java 80.32% <8.33%> (-3.01%) ⬇️
.../lambda/powertools/parameters/SecretsProvider.java 65.85% <10.00%> (-0.82%) ⬇️
...azon/lambda/powertools/parameters/SSMProvider.java 87.14% <70.00%> (+6.26%) ⬆️
...zon/lambda/powertools/parameters/ParamManager.java 77.77% <100.00%> (+0.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottgerring scottgerring merged commit b6b118f into main Jul 12, 2023
@scottgerring scottgerring deleted the fix/param_provider_error_1280 branch July 12, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants