-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ParamManager cannot provide default SSM & Secrets providers #1282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the implementation is very good readable and understandable
...ools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/ParamManager.java
Show resolved
Hide resolved
...ools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/ParamManager.java
Outdated
Show resolved
Hide resolved
...ools-parameters/src/main/java/software/amazon/lambda/powertools/parameters/ParamManager.java
Outdated
Show resolved
Hide resolved
…ertools/parameters/ParamManager.java missing issue number
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
============================================
+ Coverage 79.08% 79.18% +0.10%
- Complexity 634 639 +5
============================================
Files 73 73
Lines 2352 2359 +7
Branches 256 258 +2
============================================
+ Hits 1860 1868 +8
+ Misses 412 410 -2
- Partials 80 81 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available: #1280
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.