Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: formatter and linter #1314

Closed
wants to merge 4 commits into from
Closed

chore: formatter and linter #1314

wants to merge 4 commits into from

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available: #1290

Description of changes:

  • Creation of a checkstyle.xml file (based on google_checks, with custom severities)
  • Applied it to the whole project (looooooots of changes)

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl changed the title core : formatter and linter chore : formatter and linter Jul 26, 2023
@jeromevdl jeromevdl changed the title chore : formatter and linter chore: formatter and linter Jul 26, 2023
msailes
msailes approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes seem reasonable to me, and the main thing is that we all follow the same standard.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 37 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jeromevdl jeromevdl closed this Jul 26, 2023
@jeromevdl
Copy link
Contributor Author

jeromevdl commented Jul 26, 2023 •
edited
Loading

Will restart from an updated main... too many conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msailes msailes msailes approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromevdl @msailes