Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve contributing guide #1334

Merged
merged 5 commits into from
Aug 3, 2023
Merged

docs: improve contributing guide #1334

merged 5 commits into from
Aug 3, 2023

Conversation

jeromevdl
Copy link
Contributor

@jeromevdl jeromevdl commented Aug 2, 2023

Issue #, if available: #1295

Description of changes:

Improve the contributing guide with further content, especially checkstyle for code style.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl
Copy link
Contributor Author

jeromevdl commented Aug 2, 2023

I will open a new issue (#1335) to add gitpod configuration so that anyone can quickly start a new cloud dev environment (available in Python)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jeromevdl jeromevdl requested a review from kozub August 2, 2023 14:04
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Eleni Dimitropoulou <12170229+eldimi@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeromevdl jeromevdl merged commit 7f6c892 into main Aug 3, 2023
4 checks passed
@jeromevdl jeromevdl deleted the docs/contributing branch August 3, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants