Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing projects and improve workflow #1487

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Change the cd to working-directory
  • add missing projects

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl marked this pull request as draft October 23, 2023 13:24
@jeromevdl jeromevdl marked this pull request as ready for review October 23, 2023 13:58
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment and then an approval

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (228c0d8) 78.94% compared to head (a2030fa) 79.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1487      +/-   ##
============================================
+ Coverage     78.94%   79.80%   +0.85%     
- Complexity      651      741      +90     
============================================
  Files            74       90      +16     
  Lines          2508     2778     +270     
  Branches        259      294      +35     
============================================
+ Hits           1980     2217     +237     
- Misses          446      469      +23     
- Partials         82       92      +10     

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeromevdl jeromevdl merged commit 5f26c76 into main Oct 24, 2023
17 checks passed
@jeromevdl jeromevdl deleted the chore/update-build-workflow branch October 24, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants