perf: Make UrlConnectionHttpClient default client for params fetch #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromevdl
reviewed
Nov 20, 2020
| @@ -78,7 +80,10 @@ | |||
| * Use the {@link SSMProvider.Builder} to create an instance of it. | |||
| */ | |||
| SSMProvider(CacheManager cacheManager) { | |||
| this(cacheManager, SsmClient.create()); | |||
| this(cacheManager, SsmClient.builder() | |||
There was a problem hiding this comment.
the blog post also mention: .region(Region.of(System.getenv(SdkSystemSetting.AWS_REGION.environmentVariable())))
why don't you add it?
There was a problem hiding this comment.
Yeah good point. I can add this too.
| @@ -58,7 +60,10 @@ | |||
| * Use the {@link Builder} to create an instance of it. | |||
| */ | |||
| SecretsProvider(CacheManager cacheManager) { | |||
| this(cacheManager, SecretsManagerClient.create()); | |||
| this(cacheManager, SecretsManagerClient.builder() | |||
| .httpClientBuilder(UrlConnectionHttpClient.builder()) | |||
vitodegiosa
approved these changes
Nov 26, 2020
vitodegiosa
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #181
Also https://aws.amazon.com/blogs/developer/tuning-the-aws-java-sdk-2-x-to-reduce-startup-time/
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.