Fix attribute merging priority order & mutation

aws-powertools · Feb 8, 2022 · 362c3ed · 362c3ed
1 parent 5c7ebbe
commit 362c3ed
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/logger/src/Logger.ts b/packages/logger/src/Logger.ts
@@ -174,7 +174,7 @@ class Logger implements ClassThatLogs {
    * @returns {void}
    */
   public addPersistentLogAttributes(attributes?: LogAttributes): void {
-    this.persistentLogAttributes = merge(attributes, this.getPersistentLogAttributes());
+    merge(this.persistentLogAttributes, attributes);
   }
 
   /**
@@ -362,7 +362,7 @@ class Logger implements ClassThatLogs {
    */
   private addToPowertoolLogData(...attributesArray: Array<Partial<PowertoolLogData>>): void {
     attributesArray.forEach((attributes: Partial<PowertoolLogData>) => {
-      this.powertoolLogData = merge(attributes, this.getPowertoolLogData());
+      merge(this.powertoolLogData, attributes);
     });
   }