Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: metrics rename purgeStoredMetrics to publishStoredMetrics #301

Closed
flochaz opened this issue Dec 13, 2021 · 2 comments
Closed

Feature request: metrics rename purgeStoredMetrics to publishStoredMetrics #301

flochaz opened this issue Dec 13, 2021 · 2 comments
Assignees
@flochaz
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility good-first-issue Something that is suitable for those who want to start contributing metrics This item relates to the Metrics Utility
Milestone
production-ready-...

Comments

@flochaz
Copy link
Contributor

flochaz commented Dec 13, 2021

Description of the feature request

Problem statement

purgeStoredMetrics can be confusing and be understood as dropping metrics.

Summary of the feature

Propose by @ijemmy to change it to publishStoredMetrics (#285 (comment)).

Related issues, RFCs

#285 (comment)
@flochaz flochaz mentioned this issue Dec 13, 2021
Merged
10 tasks
@dreamorosi dreamorosi added good-first-issue Something that is suitable for those who want to start contributing metrics This item relates to the Metrics Utility labels Dec 13, 2021
@dreamorosi dreamorosi added this to the production-ready-release milestone Dec 13, 2021
@flochaz flochaz self-assigned this Jan 3, 2022
@flochaz flochaz mentioned this issue Jan 3, 2022
Merged
10 tasks
@ijemmy
Copy link
Contributor

ijemmy commented Jan 10, 2022

PR #377 has solved this.

@ijemmy ijemmy closed this as completed Jan 10, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title (metrics): rename purgeStoredMetrics to publishStoredMetrics Feature request: metrics rename purgeStoredMetrics to publishStoredMetrics Nov 14, 2022
@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility completed This item is complete and has been merged/shipped labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flochaz flochaz

Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility good-first-issue Something that is suitable for those who want to start contributing metrics This item relates to the Metrics Utility
Projects
None yet
Milestone
production-ready-release
Development

No branches or pull requests
3 participants
@ijemmy @flochaz @dreamorosi