feat(metrics): rename method purgeStoredMetrics to publishStoredMetrics #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flochaz
commented
Jan 3, 2022
| @@ -2,9 +2,9 @@ | |||
| // SPDX-License-Identifier: MIT-0 | |||
|
|
|||
There was a problem hiding this comment.
A following PR will focus on refactoring e2e test to reuse tracing one
dreamorosi
approved these changes
Jan 3, 2022
ijemmy
reviewed
Jan 3, 2022
| ) | ||
| .promise(); | ||
|
|
||
| // Despite lambda has been called twice, coldstart metric sum should only be 1 | ||
| const singleDataPoint = coldStartMetricStat.Datapoints ? coldStartMetricStat.Datapoints[0] : {}; | ||
| expect(singleDataPoint.Sum).toBe(1); | ||
| }, 9000000); | ||
| }); | ||
| }, 15000); |
There was a problem hiding this comment.
(minor) timeout is in ms. Will 15 sec be sufficient?
There was a problem hiding this comment.
Yes the test itself is quite fast. but since we sleep for 10s to get metrics ingested it still takes around 11sec
ijemmy
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
purgeStoredMetrics is confusing, renaming to publishStoredMetrics.
How to verify this change
Related issues, RFCs
#301
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.