-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(idempotency): remove decorators #1554
chore(idempotency): remove decorators #1554
Conversation
@mergify rebase |
✅ Branch has been successfully rebased |
5d9b98d
to
c63768d
Compare
Successful integration tests: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5391493794 |
We should probably also remove references in the documentation. |
Good catch Alex, I have updated the README and removed all references. While there, I also added a section for the Middy Middleware and consolidated the examples under their respective title.
Now it's
Also, I noticed that the Finally, as a side note, I noticed that when we use intersection types the documentation for those resulting types is not rendered correctly. For instance, even though we wrote the docstring for This is because the actual properties are in the base type. Apparently this is an intended behavior in typedoc: TypeStrong/typedoc#1021. For now I added a |
@am29d addressed the comments, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of your changes
As described in the linked issue, this PR removes the Idempotency decorators from the current implementation which will be soon released as public beta. For more info on why we decided to remove them, please refer to #1553.
Related issues, RFCs
Issue number: #1553
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.