Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(tracer): bump aws-xray-sdk-core to latest #1769

Merged
merged 1 commit into from
Oct 30, 2023
Merged

build(tracer): bump aws-xray-sdk-core to latest #1769

merged 1 commit into from
Oct 30, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR bumps the dependency to the aws-xray-sdk-core in the Tracer utility to the latest version released at the time of writing 3.5.3. This release includes a PR (aws/aws-xray-sdk-node#619) that our team has contributed to the X-Ray SDK that allows customers to include BigInt objects in the metadata of segments.

Prior to this release the X-Ray SDK would throw a runtime exception when it encountered a BigInt causing data loss.

Related issues, RFCs

Issue number: closes #1713

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Oct 30, 2023
@dreamorosi dreamorosi requested a review from a team as a code owner October 30, 2023 22:45
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Oct 30, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Oct 30, 2023
@dreamorosi dreamorosi changed the title build(tracer): bump aws-xray-sdk-core to latest build(tracer): bump aws-xray-sdk-core to latest Oct 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dreamorosi dreamorosi merged commit 2ad37b1 into main Oct 30, 2023
13 checks passed
@dreamorosi dreamorosi deleted the chore/bump-xray-sdk branch October 30, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dreamorosi dreamorosi

Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XS PR between 0-9 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: support BigInt serialization in segment metadata
1 participant
@dreamorosi