Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cicd): fix lerna version not bumping and publishing all packages #480

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 17, 2022

Description of your changes

0.3.1 -> 0.3.2 publication didn't bumped and published commons and tracer.

Probably a lerna issue ignoring --force-publish option. This PR remove --conventional-graduate which seems to be the option that make --force-publish option to not behave properly.

How to verify this change

Run with --conventional-graduate

npx lerna version --force-publish=\* --no-git-tag-version --no-push  --conventional-commits --conventional-graduate
lerna notice cli v4.0.0
lerna info current version 0.3.2
lerna WARN conventional-graduate all packages
lerna info Graduating all prereleased packages
lerna info Looking for changed packages since v0.3.2
lerna success No changed packages to version 

Run without it

npx lerna version --force-publish=\* --no-git-tag-version --no-push  --conventional-commits                        
lerna notice cli v4.0.0
lerna info current version 0.3.2
lerna WARN force-publish all packages
lerna info Assuming all packages changed
lerna WARN version Skipping working tree validation, proceed at your own risk
lerna info getChangelogConfig Successfully resolved preset "conventional-changelog-angular"

Changes:
 - @aws-lambda-powertools/commons: 0.3.2 => 0.3.3
 - @aws-lambda-powertools/logger: 0.3.2 => 0.3.3
 - @aws-lambda-powertools/metrics: 0.3.2 => 0.3.3
 - @aws-lambda-powertools/tracer: 0.3.2 => 0.3.3

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 17, 2022
@dreamorosi dreamorosi merged commit 0cabc3f into main Jan 17, 2022
@dreamorosi dreamorosi deleted the fix/cicdPublish branch January 17, 2022 17:33
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants