Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(all): add concurrency to github workflows #499

Merged
merged 12 commits into from
Jan 25, 2022
Merged

build(all): add concurrency to github workflows #499

merged 12 commits into from
Jan 25, 2022

Conversation

saragerion
Copy link
Contributor

@saragerion saragerion commented Jan 21, 2022 •
edited
Loading

Description of your changes

This PR adds concurrency limit of 1 to some github workflow.
This change should prevent race conditions when performing actions over the project.
The behaviour of the affected workflow will be that if one workflow of the same group is already running, the new one will be queued and performed after the old one is done.

How to verify this change

This problem happens often when you merge dependabot PRs one after the other, or it can happen with any PR into main.
Allow applicable for e2e tests.

Screenshot 2022-01-21 at 16 13 51

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saragerion saragerion added bug Something isn't working automation This item relates to automation labels Jan 21, 2022
@saragerion saragerion added this to the production-ready-release milestone Jan 21, 2022
dreamorosi
dreamorosi previously approved these changes Jan 21, 2022
View reviewed changes
flochaz and others added 7 commits January 24, 2022 14:15
@flochaz
chore(examples): fix version bumping of examples (#498)
53cabd1 
* force fix version of deps for examples

* add package.json to bump commit
@dependabot
build(deps): bump aws-sdk from 2.1056.0 to 2.1062.0 (#506)
dd71104 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1056.0 to 2.1062.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1056.0...v2.1062.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump @aws-sdk/client-sts from 3.46.0 to 3.48.0 (#505)
a84c1e6 
Bumps [@aws-sdk/client-sts](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-sts) from 3.46.0 to 3.48.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sts/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.48.0/clients/client-sts)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-sts"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump typescript from 4.5.4 to 4.5.5 (#507)
11356ee 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.4...v4.5.5)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/node from 17.0.8 to 17.0.10 (#488)
988578c 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.8 to 17.0.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dreamorosi
fix(logger|metrics): properly return decorated class (#489)
014c5bd 
* fix: logger to return decorated class

* fix: metrics to return decorated class

* chore: remove leftover files from logger
feat: Add codespaces/gitpod support (#485)
ed6f258 
* feat: initial codespaces support

* chore: example commit to disable a plugin

* fix: rather use lerna-ci

* fix: forgot to remove "cd "to examples

* feat: Add gitpod support

* chore: move to node 14 for both gitpod and codespaces

* fix: gitpod specific way

* chore: use nvmrc to ease shared config

* docs: comment out docs for gitpod

* fix: force npm to be 8

* feat: finalize extensions

* chore: remove ones that don't work

* fix: container typo
flochaz
flochaz previously approved these changes Jan 25, 2022
View reviewed changes
@saragerion saragerion dismissed stale reviews from flochaz and dreamorosi via 1fc5bd1 January 25, 2022 09:14
dreamorosi
dreamorosi approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & checks are passing

@saragerion saragerion merged commit 900aba9 into main Jan 25, 2022
@saragerion saragerion deleted the fix/github-actions-concurrency branch January 25, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

@flochaz flochaz flochaz approved these changes

Assignees

@saragerion saragerion

Labels
automation This item relates to automation bug Something isn't working
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging this pull request may close these issues.
4 participants
@saragerion @flochaz @dreamorosi @michaelbrewer