Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEDA] Update helm values to work from v2.14.0 #1024

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

vumdao
Copy link
Contributor

@vumdao vumdao commented Jun 20, 2024

Issue:
Since v2.14.0, #625 updates some Helm chart values that are not backward compatible with the old settings. The serviceAccount has been separated per service, such as operator, metricServer, and webhooks.This causes the upgrade to v2.14.0+ to recreate the new operator serviceAccount without the IAM role annotation

Description of changes:

  • Update version to current latest v2.14.2
  • Move creating namespace out of irsaRole condition check to avoid CDK delete keda namespace if we change irsaRole[] to empty
  • Remove workaround for SQS Scalar Support IRSA for SQS Scalar kedacore/keda#837 as KEDA-is-secure-by-default
  • Update serviceAccount to serviceAccount.operator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vumdao Thanks for the PR. Have couple of comments.

lib/addons/keda/index.ts Show resolved Hide resolved
lib/addons/keda/index.ts Show resolved Hide resolved
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

podSecurityContextFsGroup as well as security context fields: they are not supported by the version that is now the default version, let's add deprecation to these fields and a note that these have no effect for version 2.14 and above.
There is also impact to docs/addons/keda.md, but you can defer it.

Other than that looks great.

@vumdao vumdao requested a review from elamaran11 June 21, 2024 14:55
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vumdao Looks great.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11
Copy link
Collaborator

/do-e2e-tests

1 similar comment
@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

Failure in e2e unrelated to the changes here.
FAIL test/cloudwatch-insights.test.ts

I will create a PR to fix them and rerun.

@elamaran11
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11 elamaran11 merged commit 6737b2d into aws-quickstart:main Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants