Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded CloudWatchInsight to v1.7 and fixed unit tests #1025

Merged
merged 2 commits into from
Jun 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/addons/cloud-watch-insights/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {KubernetesVersion} from "aws-cdk-lib/aws-eks";
// aws eks describe-addon-versions --kubernetes-version <kubernetes-version> --addon-name amazon-cloudwatch-observability \
// --query 'addons[].addonVersions[].{Version: addonVersion, Defaultversion: compatibilities[0].defaultVersion}' --output table
const versionMap: Map<KubernetesVersion, string> = new Map([
[KubernetesVersion.V1_29, "v1.5.5-eksbuild.1"],
[KubernetesVersion.V1_28, "v1.5.5-eksbuild.1"],
[KubernetesVersion.V1_27, "v1.5.5-eksbuild.1"],
[KubernetesVersion.V1_26, "v1.5.5-eksbuild.1"],
[KubernetesVersion.V1_29, "v1.7.0-eksbuild.1"],
[KubernetesVersion.V1_28, "v1.7.0-eksbuild.1"],
[KubernetesVersion.V1_27, "v1.7.0-eksbuild.1"],
[KubernetesVersion.V1_26, "v1.7.0-eksbuild.1"],
]);


Expand Down
2 changes: 1 addition & 1 deletion lib/addons/karpenter/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import * as assert from "assert";
import * as sqs from 'aws-cdk-lib/aws-sqs';
import { Rule } from 'aws-cdk-lib/aws-events';
import { SqsQueue } from 'aws-cdk-lib/aws-events-targets';
import { Cluster, KubernetesVersion, KubernetesManifest } from 'aws-cdk-lib/aws-eks';
import { Cluster, KubernetesVersion } from 'aws-cdk-lib/aws-eks';

class versionMap {
private static readonly versionMap: Map<string, string> = new Map([
Expand Down
2 changes: 1 addition & 1 deletion test/cloudwatch-insights.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ describe('Unit test for CloudWatch Addon', () => {

template.hasResource("AWS::EKS::Addon", {
Properties: {
"AddonVersion": Match.exact("v1.4.0-eksbuild.1")
"AddonVersion": Match.exact("v1.7.0-eksbuild.1")
}
});
});
Expand Down
Loading