flag for deploy to isolated subnet #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezdomniy
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
shapirov103
reviewed
Sep 5, 2024
There was a problem hiding this comment.
@bezdomniy great work, definitely makes it more convenient to create isolated clusters. Implementation looks straightforward to me.
I will need to test it out, and atm our examples cluster is already overloaded with different use cases, so I will run it manually.
Please add your test case (functional) to https://github.com/aws-quickstart/cdk-eks-blueprints/blob/main/examples/examples.ts.
We are building an approach to run multiple e2e validation flows, so once it is in the codified form, it will be easy for me to migrate it to the fully automated approach.
|
I tested this PR, and it did solve my problem. I was able to deploy EKS in an isolated subnet. |
|
Validated by @jeremymcgee73 (thank you!). Merging. |
shapirov103
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add support for deploying Cluster resource in an isolated subnet. CDK EKS already supports deployment in an isolated subnet and this is describes in this example: https://github.com/aws-samples/aws-cdk-examples/tree/main/java/eks/private-cluster. This PR just adds an "isolatedCluster" flag, which adds Cluster props to based on the example.
Tested and deployed successfully.
Note that given the lack of internet access, addon's which require access to public repositories (like AwsLoadBalancerControllerAddOn) cannot be used.