Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new scraping jobs for KSH and KCM metrics #1103

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

ashoksrirama
Copy link
Contributor

Issue #, if available:

Description of changes:
Added new jobs to scrape kube-scheduler and kube-controller-manager metrics from EKS. This will be released on 11/18.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @shapirov103 Please check from your end.

@elamaran11
Copy link
Collaborator

/do-e2e-tests

@elamaran11
Copy link
Collaborator

@ashoksrirama Did you test it with our blueprint as E2E in this repo?

aws-ia-ci
aws-ia-ci previously approved these changes Nov 15, 2024
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11
Copy link
Collaborator

@ashoksrirama Auto E2E is passed. As discussed, please work on update the latest AddonVersion to all K8s version in CW Insights addon for cleaner tests before merge.

@ashoksrirama
Copy link
Contributor Author

Fixed the make run-test errors, and tested the changes with blueprint-construct-dev blueprint. I was able to visualize the AMP metrics via AMG as shown below.

image (29)

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11 elamaran11 merged commit fe93c35 into aws-quickstart:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants