Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Modify cloudwatch common to depend on gtest, gmock #19

Merged
merged 5 commits into from
Jun 26, 2019

Conversation

ross-desmond
Copy link
Contributor

Use the macro in aws_common to find test dependencies for ROS1 or ROS2.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mm318 mm318 force-pushed the test-dependency-macro branch from 069f09b to 0069375 Compare May 23, 2019 05:58
ross-desmond and others added 3 commits June 24, 2019 14:46
Use the macro in aws_common to find test dependencies for ROS1 or ROS2.

Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
…ames

Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318 mm318 force-pushed the test-dependency-macro branch from 0069375 to 0a697dc Compare June 24, 2019 22:11
mm318 added 2 commits June 24, 2019 15:26
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #19 into master will increase coverage by 3.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   84.18%   87.35%   +3.17%     
==========================================
  Files          21       22       +1     
  Lines        1018      981      -37     
==========================================
  Hits          857      857              
+ Misses        161      124      -37
Flag Coverage Δ
#ROS_1 87.35% <ø> (+3.17%) ⬆️
#kinetic ?
#melodic 87.35% <ø> (-0.54%) ⬇️
Impacted Files Coverage Δ
...atch_metrics_common/src/metric_manager_factory.cpp 0% <0%> (ø)
cloudwatch_logs_common/test/log_manager_test.cpp 100% <0%> (+5.47%) ⬆️
cloudwatch_logs_common/test/log_publisher_test.cpp 85.88% <0%> (+9.84%) ⬆️
...dwatch_logs_common/test/cloudwatch_facade_test.cpp 100% <0%> (+12.14%) ⬆️
cloudwatch_logs_common/test/shared_object_test.cpp 100% <0%> (+26.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c69f8...7db68a6. Read the comment docs.

@ross-desmond ross-desmond merged commit 530462b into master Jun 26, 2019
@ross-desmond ross-desmond deleted the test-dependency-macro branch June 26, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants