This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Use standard CMake macros for adding gtest/gmock tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
…ames Signed-off-by: Miaofei <miaofei@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 4 4
Lines 434 434
=======================================
Hits 417 417
Misses 17 17
Continue to review full report at Codecov.
|
| target_link_libraries(test_log_node_param_helper ${PROJECT_NAME}_lib | ||
| ${GTEST_LIBRARIES} libgmock ${catkin_LIBRARIES}) | ||
| add_test(NAME test_log_node_param_helper COMMAND test_log_node_param_helper --gtest_output=xml:test_results/) | ||
| add_rostest_gtest(test_log_node |
There was a problem hiding this comment.
Is roscore necessary for these tests?
There was a problem hiding this comment.
I made this change so that the way we're adding Cloud Extensions tests are consistent across all packages/repositories.
ross-desmond
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.