Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 CI adjustments #42

Merged
merged 6 commits into from
Jul 15, 2019
Merged

ROS2 CI adjustments #42

merged 6 commits into from
Jul 15, 2019

Conversation

AAlon
Copy link
Contributor

@AAlon AAlon commented Jul 12, 2019

  • Remove gtest preinstallation (ament takes care of that)
  • Setup master build like in ros1

Build passes with this change: https://travis-ci.com/AAlon/utils-ros2-copy/builds/119010363

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mm318
Copy link
Contributor

mm318 commented Jul 13, 2019

I'm thinking we should remove this, because this is ROS2 so [ "${ROS_VERSION}" == "1" ] should never be true.

ros2_build.sh Show resolved Hide resolved
@AAlon
Copy link
Contributor Author

AAlon commented Jul 15, 2019

I'm thinking we should remove this, because this is ROS2 so [ "${ROS_VERSION}" == "1" ] should never be true.

Makes sense, removed.

@AAlon AAlon merged commit 80ac4a5 into aws-robotics:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants