make the CI fail if the sample app fails to build #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
|
have you tried building an SA using this commit? would like to see a passing build. |
Signed-off-by: Miaofei <miaofei@amazon.com>
|
See passing CI build here: https://travis-ci.org/aws-robotics/aws-robomaker-sample-application-persondetection/builds/561112495 |
xabxx
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
It turned out that currently in the
ws_builds/robot_ws.shandws_builds/simulation_ws.shscripts, ifcolcon buildfails, it will continue on to doingcolcon bundle, and the CI will even be considered passing.This fix adds
set -eto those scripts so that the CI will fail if the build fails.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.