Refactor to reduce code duplication in SA build scripts #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 12 12
Lines 322 322
=======================================
Hits 284 284
Misses 38 38
Continue to review full report at Codecov.
|
ryanewel
approved these changes
Oct 3, 2019
mm318
reviewed
Oct 3, 2019
mm318
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These steps are quite generic, I expect most of them to remain as is. In case we need to have ROS1/ROS2 specific flows we can always use the ROS_VERSION env var for that or move back some parts into the version-specific scripts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.