Source Upload override and independent stage support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to reduce duplication
AAlon
changed the title
AAlon
changed the title
mm318
reviewed
Oct 3, 2019
mm318
reviewed
Oct 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 12 12
Lines 322 322
=======================================
Hits 284 284
Misses 38 38
Continue to review full report at Codecov.
|
mm318
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving on top of #59 by adding the ability to specify a dedicated upload-sources stage.
Added
ros_bootstrap.shto use for setting up some basic ROS dependencies and refactored the build scripts once more.Intentionally not sourcing it because nothing should be imported from it into the environment.
Intentionally not including colcon and colcon-bundle because of recent discussions around changing the way it is installed. The idea is that we should "never" (read: very rarely) need to touch
ros_bootstrap.sh.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.