Remove ROS1 sources from ROS2 builds #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 14 14
Lines 321 321
=======================================
Hits 283 283
Misses 38 38
Continue to review full report at Codecov.
|
raghaprasad
approved these changes
Jun 2, 2020
mm318
commented
Jun 2, 2020
| @@ -1,9 +1,6 @@ | |||
| #!/bin/bash | |||
| set -xe | |||
|
|
|||
| # add keys and sources | |||
| sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 421C365BD9FF1F717815A3895523BAEEB01FA116 | |||
There was a problem hiding this comment.
This is also the old key that should no longer be used anyways (https://discourse.ros.org/t/new-gpg-keys-deployed-for-packages-ros-org/9454).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I think this is a leftover antiquity from a time when ROS2 still needs to be bootstrapped with packages from ROS1. This is no longer the case and it needs to be removed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.